Skip to content

Remove requests and support async logging #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove requests and support async logging #876

wants to merge 2 commits into from

Conversation

@Marc-Andrieu
Copy link
Member

@Marc-Andrieu Marc-Andrieu commented Oct 14, 2025

Description

Summary

Split #845 into a 3rd PR with only the removal of requests and its major consequence: send logs asynchronously.

Changes Made

  • replace all requests use with httpx, or remove it
    • consequence: the asynchronicity of sending logs propagates, and is escaped using FastAPI's BackgroundTasks

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other

Testing

  • Added/modified tests that pass the CI
  • Tested in a pre-prod
  • Tested this locally

Documentation

  • Updated docs accordingly (docs.myecl.fr) :
  • Code includes docstrings
  • No documentation needed

@Marc-Andrieu Marc-Andrieu self-assigned this Oct 14, 2025
@Marc-Andrieu Marc-Andrieu added dependencies Pull requests that update a dependency file core logging ready for review This PR is ready to be reviewed labels Oct 14, 2025
@Marc-Andrieu Marc-Andrieu changed the title Rm/req Remove requests and support async logging Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.67%. Comparing base (513a563) to head (1f7a908).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files         189      189           
  Lines       14572    14573    +1     
=======================================
+ Hits        12485    12486    +1     
  Misses       2087     2087

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu mentioned this pull request Oct 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Marc-Andrieu Marc-Andrieu

Labels

core dependencies Pull requests that update a dependency file logging ready for review This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marc-Andrieu